-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Closed
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderstelemetryTelemetry system issuesTelemetry system issues
Milestone
Description
In order to determine the % of users that have shell integration and what quality, a large portion of terminals that are expected not to have shell integration are remote terminals. I don't think we can slice this currently, but if we add a remoteAuthority of the terminal's cwd I think we'd be able to confirm this by checking that it's undefined when the greater session has a remote authority set.
vscode/src/vs/workbench/contrib/terminal/browser/terminalTelemetry.ts
Lines 67 to 83 in 3446d06
| type TerminalCreationTelemetryData = { | |
| location: string; | |
| shellType: TelemetryTrustedValue<string>; | |
| promptType: TelemetryTrustedValue<string | undefined>; | |
| isCustomPtyImplementation: boolean; | |
| isExtensionOwnedTerminal: boolean; | |
| isLoginShell: boolean; | |
| isReconnect: boolean; | |
| shellIntegrationQuality: number; | |
| shellIntegrationInjected: boolean; | |
| shellIntegrationInjectionFailureReason: ShellIntegrationInjectionFailureReason | undefined; | |
| terminalSessionId: string; | |
| }; |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderstelemetryTelemetry system issuesTelemetry system issues