Skip to content

Explore adding remoteAuthority to create terminal event #273142

@Tyriar

Description

@Tyriar

In order to determine the % of users that have shell integration and what quality, a large portion of terminals that are expected not to have shell integration are remote terminals. I don't think we can slice this currently, but if we add a remoteAuthority of the terminal's cwd I think we'd be able to confirm this by checking that it's undefined when the greater session has a remote authority set.

type TerminalCreationTelemetryData = {
location: string;
shellType: TelemetryTrustedValue<string>;
promptType: TelemetryTrustedValue<string | undefined>;
isCustomPtyImplementation: boolean;
isExtensionOwnedTerminal: boolean;
isLoginShell: boolean;
isReconnect: boolean;
shellIntegrationQuality: number;
shellIntegrationInjected: boolean;
shellIntegrationInjectionFailureReason: ShellIntegrationInjectionFailureReason | undefined;
terminalSessionId: string;
};

Metadata

Metadata

Assignees

Labels

debtCode quality issuesinsiders-releasedPatch has been released in VS Code InsiderstelemetryTelemetry system issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions