Maximum call stack size exceeded, renderer frozen for a couple of seconds

[jrieken]

• in TS
• type a line comment
• 💥 the renderer freezes

ERR Maximum call stack size exceeded: RangeError: Maximum call stack size exceeded
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21636
    at Array.map (<anonymous>)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21632)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21710)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21710)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21710)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21710)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21710)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21710)
    at t8e (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:474:21710)
error @ log.ts:460

log.ts:450  WARN [perf] Renderer reported VERY LONG TASK (4300ms), starting profiling session '0ef14a00-918b-4552-86e0-b44ff7bb8a03'
warn @ log.ts:450

I have clicked around on the callstack and I can confidently say that this comes from here

vscode/src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsSource.ts

Lines 676 to 689 in a2ad562

	function mapDeep(value: unknown, replacer: (value: unknown) => unknown): unknown {
	const val = replacer(value);
	if (Array.isArray(val)) {
	return val.map(v => mapDeep(v, replacer));
	} else if (isObject(val)) {
	const result: Record<string, unknown> = {};
	for (const [key, value] of Object.entries(val)) {
	result[key] = mapDeep(value, replacer);
	}
	return result;
	}
	return val;
	}

[vs-code-engineering]

Hi @jrieken. As a member of the team, you can help us triage this issue by referring to https://github.com/microsoft/vscode-copilot/wiki/Copilot-Inbox-Tracker and assigning an owner directly.

[jrieken]

Maybe cloneAndChange should be used here, it doesn't recurse endlessly

[jrieken]

This reproduces very easily and eventually crashes the renderer:

Trace-20251127T134612.json.gz