-
Notifications
You must be signed in to change notification settings - Fork 39k
Regression in Search: Literal Search Misses Matches That Regex Finds #280939
Copy link
Copy link
Open
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugsearchSearch widget and operation issuesSearch widget and operation issues
Description
Does this issue occur when all extensions are disabled?: Yes
- VS Code Version: 1.106.3
- OS Version: Windows 11 Enterprise/26100.7171
Steps to Reproduce:
- Open a C/C++ project with these lines:
//#define HAVE_VERBOSE_MESSAGES /* Recommended during development prints errors and warnings */#if defined(HAVE_VERBOSE_MESSAGES)Show more lines - Search for HAVE_VERBOSE_MESSAGES with regex disabled.
- Enable regex and search again.
- Compare results.
Comments:
The new search implementation in VS Code appears to have a regression. When searching for a simple string like HAVE_VERBOSE_MESSAGES when Regular Expression enabled/disabled:
- Regex disabled (literal search): Finds only one match in the header where it is defined:
/#define HAVE_VERBOSE_MESSAGES /* Recommended during development prints errors and warnings */ - Regex enabled: Finds two matches (both correct) in the definition header and in another file:
-- first match
/#define HAVE_VERBOSE_MESSAGES /* Recommended during development prints errors and warnings */
-- SECOND MATCH
#if defined(HAVE_VERBOSE_MESSAGES)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugsearchSearch widget and operation issuesSearch widget and operation issues