The unsaved (dot) indicator doesn't update when file is opened from the source control diff section

[01abhishekjain]

• VSCode Version: 1.13.0
• OS Version: MacOS Sierra 10.12.4

Steps to Reproduce:

1. open the diff view for any file from the Source Control panel
2. click the Open File button at the top-right corner of vscode
3. make an edit
4. save the file

What I saw: the dot indicator remained .. like a dot.
Expected: the dot indicator should have become the cross icon

[bpasero]

@01abhishekjain I cannot reproduce, can you share a video? Does this reproduce all the time? Does it reproduce with extensions disabled?

[01abhishekjain]

@bpasero

I can reproduce even with all extensions disabled. I'd say it reproduces almost all the time. Out of the blue, it once worked correctly (with the extensions enabled). But since then I have observed it to be reproducible each time I try.

Edit: once in the GIF, you'll notice I have opened a menu; that's just to save the file.

[bpasero]

@01abhishekjain could it be that you have auto save enabled in settings?

[01abhishekjain]

No, I don't.

[bpasero]

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

[01abhishekjain]

I already checked that it's not caused by any extension. I again tried to open VS Code via code --disable-extension but the issue is still being reproduced.

:/

[bpasero]

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

[01abhishekjain]

Reproducible on Insider build Version 1.14.0-insider (1.14.0-insider)