Terminal tool doesn't detect "press any key"

[roblourens]

sleep 1
echo "Press any key to continue..."
read -n 1 -s key
echo "You pressed: $key"
echo "Continuing..."

It doesn't detect that the script is waiting on the "press any key" prompt, because the 4o-mini prompt has "any key" examples that should not be detected and I guess it picks up on those.

db330cf9.copilotmd

I still don't understand why we need an LLM to detect Terminal will be reused by tasks, press any key to close it. since that message comes from vscode, and also don't we know that the task is finished at that point?

[roblourens]

And these strings are localized, but the prompt is hardcoded in english, so does that part work in non-english?

vscode/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Line 1977 in 655abb9

return taskShellIntegrationWaitOnExitSequence(nls.localize('reuseTerminal', 'Terminal will be reused by tasks, press any key to close it.'));

[meganrogge]

If it doesn't stop on idle, it means this is isBackground: false, which is tracked here.

#253263

[meganrogge]

Just tried and this works for me

[meganrogge]

because the 4o-mini prompt has "any key" examples that should not be detected and I guess it picks up on those.

Can you elaborate here? not following 🤔

which one?

[roblourens]

If it doesn't stop on idle, it means this is isBackground: false, which is tracked here.

I don't understand, the feature is that you detect when the command is blocked on an input request. You do that in non-bg terminals. Does your screenshot show it working? It doesn't seem like it asked you for the input?

Can you elaborate here? not following 🤔

I'm talking about the prompt you use to detect the input request. I attached it to the original issue.

[meganrogge]

When the any key thing is detected, we do not want to prompt anymore. There was alot of backlash against doing that. So in my screenshot, i'm showing that it works - aborts when we detect that line.

[roblourens]

When the any key thing is detected, we do not want to prompt anymore. There was alot of backlash against doing that

Oh interesting, what was the backlash? I don't understand why you would prompt for "press A to continue" but not for "press any key to continue", it's basically the same scenario right?

I've never seen it just continue without waiting for the script, so in your scenario, did it run in a bg terminal?

Every time I've tried this, it hangs until I manually find the terminal and unstick it, which seems suboptimal.

[meganrogge]

The backlash was partially from you 😆 - saying why are we prompting to press any key when it should just know it's finished.

#281569 also see the comments on the linked PR to this issue where users are eager for this fix to land in stable.

[meganrogge]

I don't understand why you would prompt for "press A to continue" but not for "press any key to continue", it's basically the same scenario right?

They're different - usually press A does something specific. Press any just means it's done.

[meganrogge]

I've never seen it just continue without waiting for the script, so in your scenario, did it run in a bg terminal?

When it hangs, isBackground=false which is covered in that other issue.