Text disappeared after update to 1.13 [Bug]

[tonoslav]

• VSCode Version: 1.13
• OS Version: Windows 10.0.14393

Steps to Reproduce:

1. Updated to 1.13
2. Nothing else

Update

Insider version is the same

Update 2

Downgrade to 12.2 fixed the problem

Update 3

Problem is with font-family: system-ui , how to fix it?

[ramya-rao-a]

@tonoslav Whe you say "Insider version is the same", do you mean that you see the issue in Insiders as well or Insiders works as expected and is same as before ?

[bpasero]

@tonoslav this could be due to us changing the default font in 1.13 for the workbench. Can you open the dev tools (from the help menu) and find the monaco-shell CSS class font-family:

Change this to "Arial" or "Times New Roman", does the text show up?

What are your OS font settings?

/cc @jhasse @Tyriar

[jhasse]

Could also be some caching problem. Try to delete %AppData%\Code\Cache and %AppData%\Code\CachedData while VSCode isn't running and start it again.

The font should be the same as the one for File, Edit, etc. (which does show up). But maybe it's using a different glyph cache or something?

[tonoslav]

@ramya-rao-a yeah I meant that it doesnt matter if I use normal VSCode or Insider version

@jhasse Cache clear didnt help

@bpasero I have found out that the problem is with Font-family: system-ui when I delete system-ui from fonts in developer tools, it works, how can I fix this in general?

I have found out I have this problem with system-ui font everywhere in all chromium like browsers I think, firefox for example works ok when I see website with font-family: system-ui

[jhasse]

I have found out I have this problem with system-ui font everywhere in all chromium like browsers

That's very good to know! Can you reproduce it here? https://jsfiddle.net/9yeoLewo/
I've created a Chromium bug report, maybe someone from the developers can comment on this problem: https://bugs.chromium.org/p/chromium/issues/detail?id=733219

firefox for example works ok when I see website with font-family: system-ui

Firefox doesn't support system-ui (it's an alias for the default system font).

[bpasero]

Given this bug I think we need to revert the change to use system-ui until Chrome fixed this issue. It looks like the fallback is not applied, so there does not seem to be a workaround.

[jhasse]

Yes, you should be able to revert 663608d and then 45d93e9.