Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds conditional skipping of the "workbench has no accessibility violations" smoke test when running on macOS in web mode. According to the PR description, the test is being skipped due to an "Error: Activating extension" that occurs specifically in this environment.
Key Changes
- Conditionally skips the workbench accessibility test for web on macOS using
it.skip - Adds a comment explaining the reason for skipping
| describe('Workbench', function () { | ||
|
|
||
| it('workbench has no accessibility violations', async function () { | ||
| (opts.web ? it.skip : it)('workbench has no accessibility violations', async function () { |
There was a problem hiding this comment.
The comment mentions "aria-allowed-attr violations from dynamic notification lists" but the PR description states the reason is "Error: Activating extension". These describe different issues. The comment should accurately reflect the actual problem being worked around, which according to the PR description is an extension activation error, not aria-allowed-attr violations. Additionally, the test already excludes aria-allowed-attr violations on lines 41-42, so that explanation doesn't align with the need to skip the entire test.
Seeing
Error: Activating extension, so going to just skip for this case