Skip to content

skip smoke test for web #286808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 2 commits into from
Jan 9, 2026
Merged

skip smoke test for web #286808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53d7abf
skip for web on mac
meganrogge Jan 9, 2026
ef7a2c2
skip for all web
meganrogge Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/smoke/src/areas/accessibility/accessibility.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function setup(logger: Logger, opts: { web?: boolean }) {

describe('Workbench', function () {

it('workbench has no accessibility violations', async function () {
(opts.web ? it.skip : it)('workbench has no accessibility violations', async function () {
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions "aria-allowed-attr violations from dynamic notification lists" but the PR description states the reason is "Error: Activating extension". These describe different issues. The comment should accurately reflect the actual problem being worked around, which according to the PR description is an extension activation error, not aria-allowed-attr violations. Additionally, the test already excludes aria-allowed-attr violations on lines 41-42, so that explanation doesn't align with the need to skip the entire test.

Copilot uses AI. Check for mistakes.
// Wait for workbench to be fully loaded
await app.code.waitForElement('.monaco-workbench');

Expand Down
Loading