Skip to content

fix: disable skia graphite backend#288141

Merged
deepak1556 merged 3 commits intomainfrom
robo/disable_skia_graphite
Jan 16, 2026
Merged

fix: disable skia graphite backend#288141
deepak1556 merged 3 commits intomainfrom
robo/disable_skia_graphite

Conversation

@deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Jan 15, 2026

Disabled until a fix is landed in skia, refer to https://gist.github.com/deepak1556/434964e5e379339be1d02db2a9afb743 for the conclusion towards this fix.

Fixes #284162
Fixes #263554

@deepak1556 deepak1556 added this to the January 2026 milestone Jan 15, 2026
@deepak1556 deepak1556 self-assigned this Jan 15, 2026
Copilot AI review requested due to automatic review settings January 15, 2026 18:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the Skia Graphite backend by adding a command-line switch to address rendering issues. The change is a temporary workaround until a fix lands in Skia upstream.

Changes:

  • Added disable-skia-graphite command-line switch to globally disable the Skia Graphite backend
Comments suppressed due to low confidence (1)

src/main.ts:341

  • Corrected spelling of 'Siwtch' to 'Switch'.
		`FontMatchingCTMigration,StandardizedBrowserZoom,${app.commandLine.getSwitchValue('disable-blink-features')}`;

@deepak1556 deepak1556 marked this pull request as ready for review January 16, 2026 19:22
@deepak1556 deepak1556 enabled auto-merge (squash) January 16, 2026 19:22
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/main.ts
  • src/vs/workbench/electron-browser/desktop.contribution.ts

@deepak1556 deepak1556 merged commit ae52495 into main Jan 16, 2026
22 checks passed
@deepak1556 deepak1556 deleted the robo/disable_skia_graphite branch January 16, 2026 19:25
@jsoref
Copy link
Contributor

jsoref commented Jan 18, 2026

I'm seeing this
Screenshot 2026-01-18 at 11 28 55 AM
in

Version: 1.109.0-insider (Universal)
Commit: f46196091d2fa0069d229cb638869b4ab95392cf
Date: 2026-01-16T12:14:27.330Z
Electron: 39.2.7
ElectronBuildId: 13098910
Chromium: 142.0.7444.235
Node.js: 22.21.1
V8: 14.2.231.21-electron.0
OS: Darwin arm64 25.2.0

@deepak1556
Copy link
Collaborator Author

@jsoref the change from this PR is not available in the build you are referencing. It is available from today's insider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken rendering on macOS after app resumed from idle state Rendering broken on macOS

4 participants