layout - polish icons and state for maximisation/restore#288980
Merged
layout - polish icons and state for maximisation/restore#288980
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the UI for panel and auxiliary bar maximization/restoration by introducing separate icons for maximize and restore states, and improving the menu item registration patterns.
Changes:
- Introduced dedicated restore icons (
restoreIcon) for both panel and auxiliary bar to differentiate from maximize state - Refactored panel's toggle maximize action to use separate menu registrations for maximize and restore states instead of a toggled property
- Removed dependency on panel's close icon from auxiliary bar, making it independently defined
- Enhanced auxiliary bar's close button to hide when maximized and appear as an alt action on the restore button
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/panel/panelActions.ts | Added restore icon, refactored toggle maximize action to use separate menu items for maximize/restore states with distinct icons, removed export from closeIcon |
| src/vs/workbench/browser/parts/auxiliarybar/auxiliaryBarActions.ts | Added restore icon, removed panel close icon dependency, updated close button visibility logic to hide when maximized, added alt action for close on restore button |
Comments suppressed due to low confidence (1)
src/vs/workbench/browser/parts/panel/panelActions.ts:326
- The localization key 'minimizePanel' is inconsistent with the English text "Restore Panel Size". Consider updating the localization key to 'restorePanel' or 'restorePanelSize' to match the actual text and align with the pattern used in auxiliaryBarActions.ts where 'restoreAuxiliaryBarTooltip' is used for similar functionality.
title: localize('minimizePanel', "Restore Panel Size"),
aeschli
previously approved these changes
Jan 19, 2026
lszomoru
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.