Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Jan 19, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 19, 2026 20:21
@bpasero bpasero self-assigned this Jan 19, 2026
@bpasero bpasero added this to the January 2026 milestone Jan 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the UI for panel and auxiliary bar maximization/restoration by introducing separate icons for maximize and restore states, and improving the menu item registration patterns.

Changes:

  • Introduced dedicated restore icons (restoreIcon) for both panel and auxiliary bar to differentiate from maximize state
  • Refactored panel's toggle maximize action to use separate menu registrations for maximize and restore states instead of a toggled property
  • Removed dependency on panel's close icon from auxiliary bar, making it independently defined
  • Enhanced auxiliary bar's close button to hide when maximized and appear as an alt action on the restore button

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/browser/parts/panel/panelActions.ts Added restore icon, refactored toggle maximize action to use separate menu items for maximize/restore states with distinct icons, removed export from closeIcon
src/vs/workbench/browser/parts/auxiliarybar/auxiliaryBarActions.ts Added restore icon, removed panel close icon dependency, updated close button visibility logic to hide when maximized, added alt action for close on restore button
Comments suppressed due to low confidence (1)

src/vs/workbench/browser/parts/panel/panelActions.ts:326

  • The localization key 'minimizePanel' is inconsistent with the English text "Restore Panel Size". Consider updating the localization key to 'restorePanel' or 'restorePanelSize' to match the actual text and align with the pattern used in auxiliaryBarActions.ts where 'restoreAuxiliaryBarTooltip' is used for similar functionality.
		title: localize('minimizePanel', "Restore Panel Size"),

aeschli
aeschli previously approved these changes Jan 19, 2026
@bpasero bpasero merged commit a0ac005 into main Jan 20, 2026
22 checks passed
@bpasero bpasero deleted the ben/supposed-cow branch January 20, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants