Skip to content

agent sessions - fix logging#289316

Merged
bpasero merged 1 commit intomainfrom
ben/aggressive-deer
Jan 21, 2026
Merged

agent sessions - fix logging#289316
bpasero merged 1 commit intomainfrom
ben/aggressive-deer

Conversation

@bpasero
Copy link
Copy Markdown
Member

@bpasero bpasero commented Jan 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 21, 2026 07:05
@bpasero bpasero enabled auto-merge (squash) January 21, 2026 07:05
@bpasero bpasero self-assigned this Jan 21, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the logging infrastructure in the agent sessions feature to improve code organization and clarity. The changes separate simple trace logging from comprehensive stats logging and eliminate code duplication.

Changes:

  • Split logIfTrace into two methods: logIfTrace for simple messages and logAllStatsIfTrace for comprehensive statistics
  • Introduced a private trace helper method to centralize output channel access and eliminate code duplication
  • Updated call sites to use the appropriate method based on whether they log simple messages or comprehensive stats

@bpasero bpasero merged commit 1d742f0 into main Jan 21, 2026
27 of 28 checks passed
@bpasero bpasero deleted the ben/aggressive-deer branch January 21, 2026 07:23
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants