Skip to content

agent sessions - fix logging #289316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpasero merged 1 commit into from
Jan 21, 2026
+24 −22
Merged

agent sessions - fix logging #289316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,20 @@ class AgentSessionsLogger extends Disposable {
private registerListeners(): void {
this._register(this.logService.onDidChangeLogLevel(level => {
if (level === LogLevel.Trace) {
this.logIfTrace('Log level changed to trace');
this.logAllStatsIfTrace('Log level changed to trace');
}
}));
}

logIfTrace(reason: string): void {
logIfTrace(msg: string): void {
if (this.logService.getLevel() !== LogLevel.Trace) {
return;
}

this.trace(`[Agent Sessions] ${msg}`);
}

logAllStatsIfTrace(reason: string): void {
if (this.logService.getLevel() !== LogLevel.Trace) {
return;
}
Expand All @@ -249,11 +257,6 @@ class AgentSessionsLogger extends Disposable {
}

private logAllSessions(reason: string): void {
const channel = this.outputService.getChannel(agentSessionsOutputChannelId);
if (!channel) {
return;
}

const { sessions, sessionStates } = this.getSessionsData();

const lines: string[] = [];
Expand Down Expand Up @@ -316,15 +319,10 @@ class AgentSessionsLogger extends Disposable {

lines.push(`=== End Agent Sessions ===`);

channel.append(lines.join('\n') + '\n');
this.trace(lines.join('\n'));
}

private logSessionStates(): void {
const channel = this.outputService.getChannel(agentSessionsOutputChannelId);
if (!channel) {
return;
}

const { sessionStates } = this.getSessionsData();

const lines: string[] = [];
Expand All @@ -341,15 +339,10 @@ class AgentSessionsLogger extends Disposable {

lines.push(`=== End Session States ===`);

channel.append(lines.join('\n') + '\n');
this.trace(lines.join('\n'));
}

private logMapSessionToState(): void {
const channel = this.outputService.getChannel(agentSessionsOutputChannelId);
if (!channel) {
return;
}

const { mapSessionToState } = this.getSessionsData();

const lines: string[] = [];
Expand All @@ -367,7 +360,16 @@ class AgentSessionsLogger extends Disposable {

lines.push(`=== End Map Session To State ===`);

channel.append(lines.join('\n') + '\n');
this.trace(lines.join('\n'));
}

private trace(msg: string): void {
const channel = this.outputService.getChannel(agentSessionsOutputChannelId);
if (!channel) {
return;
}

channel.append(`${msg}\n`);
}
}

Expand Down Expand Up @@ -425,7 +427,7 @@ export class AgentSessionsModel extends Disposable implements IAgentSessionsMode
mapSessionToState: this.mapSessionToState
})
));
this.logger.logIfTrace('Loaded cached sessions');
this.logger.logAllStatsIfTrace('Loaded cached sessions');

this.registerListeners();

Expand Down Expand Up @@ -618,7 +620,7 @@ export class AgentSessionsModel extends Disposable implements IAgentSessionsMode
}
}

this.logger.logIfTrace('Sessions resolved from providers');
this.logger.logAllStatsIfTrace('Sessions resolved from providers');

this._onDidChangeSessions.fire();
}
Expand Down
Loading