Skip to content

Layer breakers from tasks experiments #29080

@bpasero

Description

@bpasero

#28909 introduced quite a bit of layer breakers into the workbench.

src/vs/workbench/parts/quickopen/common/quickopenActions.ts is very task specific and as such it should move into src/vs/workbench/parts/tasks

The changes to textFileEditorModel are not fitting. showTaskNotification seems very task specific and should not go into the file world that has no knowledge around tasks. There are events (e.g. on the editor service) that can be used to listen to files opening so that this can all happen from the outside.

In addition, please stay away from using contextService.getWorkspace() and use getWorkspace2() instead which is capable of multi root information.

Thanks!

Metadata

Metadata

Labels

debtCode quality issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions