The current build is broken because a dev dependency brings in @types/node into our node_modules and we blindly take node_modules/@types/**/index.d.ts into our compilation units, done in 22fdff9. Since we already have src/typings/node.d.ts, which happens to be custom edited, the TypeScript build fails with duplicate definitions.
https://travis-ci.org/Microsoft/vscode/builds/246211414
We can't include all @types in our compilation units because that brings in dev dependencies too. Our current - flawed, yet working - approach is to simply put types into src/typings. I suggest to use that mechanism, thus reverting commit 22fdff9, until we find a proper, good solution for this.
cc @alexandrudima @jrieken
The current build is broken because a dev dependency brings in
@types/nodeinto ournode_modulesand we blindly takenode_modules/@types/**/index.d.tsinto our compilation units, done in 22fdff9. Since we already havesrc/typings/node.d.ts, which happens to be custom edited, the TypeScript build fails with duplicate definitions.https://travis-ci.org/Microsoft/vscode/builds/246211414
We can't include all
@typesin our compilation units because that brings in dev dependencies too. Our current - flawed, yet working - approach is to simply put types intosrc/typings. I suggest to use that mechanism, thus reverting commit 22fdff9, until we find a proper, good solution for this.cc @alexandrudima @jrieken