Chat: workspace trust dialog is too eager

[bpasero]

I think we really need to revisit how workspace trust shows up eager as soon as the chat view tries to render sessions:

In this case I was using --transient to have a fresh VS Code setup and went through the setup flow. Now because I have existing background sessions, I get asked for each folder eagerly, even before interacting with the session.

I think asking for workspace trust is fine but not so early, only when I engage with the session. Even if this means I do not see all the metadata yet.

[bpasero]

I am marking this as important because this actually seems to break the setup flow: notice the "Sorry no response was returned", likely because the dialog shows up.

@lszomoru @DonJayamanne as a bandaid, I would suggest for now to not add the Git repository and not trigger the trust dialog until we have figured out a better solution.

[bpasero]

Screen.Recording.2026-02-20.at.11.28.58.mov

I cannot even cancel :-(

[joaomoreno]

After discussion with @bpasero and @benibenj, we suggest to remove the discovery of changes for sessions until we have the ability to spawn harmless git commands without requiring workspace trust.

[DonJayamanne]

@joaomoreno @bpasero
I'm struggling to understand the use case here.
Or how likely users will run into this..
we're the only ones creating the worktree, hence its already trusted,

The likelyhood of anyone creating --transient vscode sessions is low, so I fail to see how this is a majority use case

[bpasero]

I am pushing a workaround to not call into getWorkspaceChanges unless the workspace is trusted.

I noticed that we seem to potentially trigger workspace trust dialogs per-session entry, so that explains why me pressing "Cancel" felt like its not working: I got a trust dialog per sessions and I had hundreds.