Skip to content

alert when an image is attached via paste#299862

Merged
meganrogge merged 2 commits intomainfrom
merogge/attachment-announcement
Mar 6, 2026
Merged

alert when an image is attached via paste#299862
meganrogge merged 2 commits intomainfrom
merogge/attachment-announcement

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

fix #299859

Copilot AI review requested due to automatic review settings March 6, 2026 20:09
@meganrogge meganrogge self-assigned this Mar 6, 2026
@meganrogge meganrogge added this to the 1.112.0 milestone Mar 6, 2026
@meganrogge meganrogge enabled auto-merge (squash) March 6, 2026 20:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses accessibility issue #299859 by adding an ARIA alert announcement when a pasted image is attached to the chat input, so screen reader users are immediately notified without having to navigate backwards through the UI to discover the attachment.

Changes:

  • Imports the alert function from base/browser/ui/aria/aria.js in chatPasteProviders.ts.
  • Computes a boolean flag announceImageAttachment to detect when a single image is being pasted, and fires an ARIA alert('Attached image') inside the redo() callback (which is invoked on both initial paste and redo operations).

Comment thread src/vs/workbench/contrib/chat/browser/widget/input/editor/chatPasteProviders.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 6, 2026

@meganrogge I've opened a new pull request, #299864, to work on those changes. Once the pull request is ready, I'll request review from you.

@meganrogge meganrogge merged commit b35cc30 into main Mar 6, 2026
20 checks passed
@meganrogge meganrogge deleted the merogge/attachment-announcement branch March 6, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

we should alert when an image gets attached to chat

4 participants