Skip to content

alert when an image is attached via paste #299862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 2 commits into from
Mar 6, 2026
Merged

alert when an image is attached via paste #299862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f36256
fix #299859
meganrogge Mar 6, 2026
350257d
Use `isImageVariableEntry()` type guard in chatPasteProviders (#299864)
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/vs/workbench/contrib/chat/browser/widget/input/editor/chatPasteProviders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import { CancellationToken } from '../../../../../../../base/common/cancellation.js';
import { Codicon } from '../../../../../../../base/common/codicons.js';
import { createStringDataTransferItem, IDataTransferItem, IReadonlyVSDataTransfer, VSDataTransfer } from '../../../../../../../base/common/dataTransfer.js';
import { alert } from '../../../../../../../base/browser/ui/aria/aria.js';
Comment thread
meganrogge marked this conversation as resolved.
import { HierarchicalKind } from '../../../../../../../base/common/hierarchicalKind.js';
import { Disposable } from '../../../../../../../base/common/lifecycle.js';
import { revive } from '../../../../../../../base/common/marshalling.js';
Expand All @@ -23,7 +24,7 @@ import { IFileService } from '../../../../../../../platform/files/common/files.j
import { IInstantiationService } from '../../../../../../../platform/instantiation/common/instantiation.js';
import { ILogService } from '../../../../../../../platform/log/common/log.js';
import { IExtensionService, isProposedApiEnabled } from '../../../../../../services/extensions/common/extensions.js';
import { IChatRequestPasteVariableEntry, IChatRequestVariableEntry } from '../../../../common/attachments/chatVariableEntries.js';
import { IChatRequestPasteVariableEntry, IChatRequestVariableEntry, isImageVariableEntry } from '../../../../common/attachments/chatVariableEntries.js';
import { IDynamicVariable } from '../../../../common/attachments/chatVariables.js';
import { IChatWidgetService } from '../../../chat.js';
import { getDynamicVariablesForWidget } from '../../../attachments/chatVariables.js';
Expand Down Expand Up @@ -386,6 +387,7 @@ function createCustomPasteEdit(model: ITextModel, context: IChatRequestVariableE
const label = context.length === 1
? context[0].name
: localize('pastedAttachment.multiple', '{0} and {1} more', context[0].name, context.length - 1);
const announceImageAttachment = context.length === 1 && isImageVariableEntry(context[0]);

const customEdit = {
resource: model.uri,
Expand All @@ -403,6 +405,9 @@ function createCustomPasteEdit(model: ITextModel, context: IChatRequestVariableE
throw new Error('No widget found for redo');
}
widget.attachmentModel.addContext(...context);
if (announceImageAttachment) {
alert(localize('chat.pastedImageAttached', 'Attached image'));
}
},
metadata: {
needsConfirmation: false,
Expand Down
Loading