Skip to content

Fix infinite enter for pwsh5 when screen reader is enabled#303242

Merged
mjbvz merged 2 commits intomainfrom
anthonykim1/fixPsreadlineRegression
Mar 19, 2026
Merged

Fix infinite enter for pwsh5 when screen reader is enabled#303242
mjbvz merged 2 commits intomainfrom
anthonykim1/fixPsreadlineRegression

Conversation

@anthonykim1
Copy link
Contributor

Resolves: #303202

@anthonykim1 anthonykim1 added this to the 1.113.0 milestone Mar 19, 2026
@anthonykim1 anthonykim1 requested a review from meganrogge March 19, 2026 16:14
@anthonykim1 anthonykim1 self-assigned this Mar 19, 2026
Copilot AI review requested due to automatic review settings March 19, 2026 16:14
@anthonykim1 anthonykim1 changed the title Fix infinite enter for windows terminal 5 when screen reader is enabled Fix infinite enter for windows terminal when screen reader is enabled Mar 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts PowerShell terminal shell integration in VS Code’s accessibility mode to avoid triggering problematic PSReadLine replacement behavior on Windows PowerShell 5.1, addressing the “infinite Enter” symptom reported after updating (issue #303202).

Changes:

  • Gate the PSReadLine removal/re-import logic to PowerShell 7.0+ to avoid replacing the built-in PSReadLine on Windows PowerShell 5.1.
  • Add inline rationale explaining why Windows PowerShell 5.1 is excluded (input handling issues).

@anthonykim1 anthonykim1 changed the title Fix infinite enter for windows terminal when screen reader is enabled Fix infinite enter for pwsh5 when screen reader is enabled Mar 19, 2026
@mjbvz mjbvz merged commit ee0567d into main Mar 19, 2026
19 checks passed
@mjbvz mjbvz deleted the anthonykim1/fixPsreadlineRegression branch March 19, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic entering after the latest update

3 participants