Skip to content

Fix infinite enter for pwsh5 when screen reader is enabled #303242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 2 commits into from
Mar 19, 2026
Merged

Fix infinite enter for pwsh5 when screen reader is enabled #303242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8712752
Fix infinite enter for windows terminal 5 when screen reader is enabled
anthonykim1 Mar 19, 2026
444471e
Merge branch 'main' into anthonykim1/fixPsreadlineRegression
anthonykim1 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/vs/workbench/contrib/terminal/common/scripts/shellIntegration.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,13 @@ if ($Global:__VSCodeState.IsA11yMode -eq "1") {
# Check if the loaded PSReadLine already supports EnableScreenReaderMode
$hasScreenReaderParam = (Get-Module -Name PSReadLine) -and (Get-Command Set-PSReadLineOption).Parameters.ContainsKey('EnableScreenReaderMode')

if (-not $hasScreenReaderParam) {
if (-not $hasScreenReaderParam -and $PSVersionTable.PSVersion -ge "7.0") {
# The loaded PSReadLine lacks EnableScreenReaderMode (only available in 2.4.4-beta4+).
# PowerShell 7.0+ skips autoloading PSReadLine when the OS reports a screen reader active.
# When only VS Code's accessibility mode is enabled (no OS screen reader),
# it's still loaded and must be removed to load our bundled copy.
# Skip this on Windows PowerShell 5.1 where removing the built-in PSReadLine 2.0.0
# and replacing it can cause input handling issues (e.g. repeated Enter key presses).
if (Get-Module -Name PSReadLine) {
Remove-Module PSReadLine -Force
}
Expand Down
Loading