Cherry-pick update indicator styling: remove post-install button and Ready hint#304615
Merged
eli-w-king merged 1 commit intoeli/then-dormousefrom Mar 25, 2026
Merged
Conversation
…cator Co-authored-by: eli-w-king <201316543+eli-w-king@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/1abb9e09-8ee3-4639-a823-8c9653a372cb
Copilot created this pull request from a session on behalf of
eli-w-king
March 25, 2026 00:50
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks just the button/animation/hover styling from
eli/then-dormousewithout the test commands infrastructure, and makes the following cleanup changes:What changed:
Removed the "Update Complete" post-install title bar button — the
showPostInstall/dismissPostInstallmethods and all related state (postInstallTimer,postInstallOptions,pendingPostInstall) have been removed fromUpdateTitleBarEntryandUpdateTitleBarContribution. The button that previously appeared and faded after a version update no longer shows.Removed the "Installed. Restart?" hint from the Ready state — when an update is ready to apply (Ready state), the title bar button now just shows "Update" with the prominent background. The sliding hint text "Installed. Restart?" and the periodic flash animation have been removed.
Removed
testShowPostInstallmethod — this was a dev-only helper used by the test commands infrastructure that is not being carried over.Removed
update.test.contribution.tsand restored its.gitignoreentry — the test commands file that was added to the repo ineli/then-dormouseis not included in this PR.Removed post-install CSS classes from
updateTitleBarEntry.css—.post-installand.post-install-fadestyles cleaned up.What's preserved:
detectVersionChangeflow still callsrenderPostInstall()on the tooltip and auto-shows the tooltip on version upgrade — only the title bar button label is removedAvailableForDownloadandDownloadedstates