Skip to content

Cherry-pick update indicator styling: remove post-install button and Ready hint#304615

Merged
eli-w-king merged 1 commit intoeli/then-dormousefrom
copilot/cherry-pick-styling-changes
Mar 25, 2026
Merged

Cherry-pick update indicator styling: remove post-install button and Ready hint#304615
eli-w-king merged 1 commit intoeli/then-dormousefrom
copilot/cherry-pick-styling-changes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

Cherry-picks just the button/animation/hover styling from eli/then-dormouse without the test commands infrastructure, and makes the following cleanup changes:

What changed:

  • Removed the "Update Complete" post-install title bar button — the showPostInstall/dismissPostInstall methods and all related state (postInstallTimer, postInstallOptions, pendingPostInstall) have been removed from UpdateTitleBarEntry and UpdateTitleBarContribution. The button that previously appeared and faded after a version update no longer shows.

  • Removed the "Installed. Restart?" hint from the Ready state — when an update is ready to apply (Ready state), the title bar button now just shows "Update" with the prominent background. The sliding hint text "Installed. Restart?" and the periodic flash animation have been removed.

  • Removed testShowPostInstall method — this was a dev-only helper used by the test commands infrastructure that is not being carried over.

  • Removed update.test.contribution.ts and restored its .gitignore entry — the test commands file that was added to the repo in eli/then-dormouse is not included in this PR.

  • Removed post-install CSS classes from updateTitleBarEntry.css.post-install and .post-install-fade styles cleaned up.

What's preserved:

  • All button/animation/hover styling (shimmer progress underline, percent fill underline, slide-out hint animation, prominent button style for actionable states)
  • The detectVersionChange flow still calls renderPostInstall() on the tooltip and auto-shows the tooltip on version upgrade — only the title bar button label is removed
  • Hints still appear for AvailableForDownload and Downloaded states

Copilot AI requested a review from eli-w-king March 25, 2026 00:50
@vs-code-engineering vs-code-engineering bot added this to the 1.114.0 milestone Mar 25, 2026
@eli-w-king eli-w-king marked this pull request as ready for review March 25, 2026 18:52
@eli-w-king eli-w-king merged commit 59f78d1 into eli/then-dormouse Mar 25, 2026
2 of 3 checks passed
@eli-w-king eli-w-king deleted the copilot/cherry-pick-styling-changes branch March 25, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants