Clear more of response on ChatResponseModel dispose#308653
Merged
roblourens merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to prior leak-mitigation work in the chat model, aiming to reduce memory retention by clearing more state when a ChatResponseModel is disposed.
Changes:
- Clear the response content on
ChatResponseModel.dispose(). - Clear
codeBlockInfoson dispose to drop references to associated metadata.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/model/chatModel.ts | Extends ChatResponseModel.dispose() to clear response and code-block metadata to reduce retention impact. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
dmitrivMS
approved these changes
Apr 9, 2026
joshspicer
pushed a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #308638