Skip to content

Clear more of response on ChatResponseModel dispose #308653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roblourens merged 1 commit into from
Apr 9, 2026
Merged

Clear more of response on ChatResponseModel dispose #308653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vs/workbench/contrib/chat/common/model/chatModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,6 +1425,10 @@ export class ChatResponseModel extends Disposable implements IChatResponseModel
super.dispose();
// Break back-reference to ChatModel to prevent retention cycles
this._session = undefined!;
this._response.clear();
Comment thread
roblourens marked this conversation as resolved.
if (this._codeBlockInfos) {
this._codeBlockInfos.length = 0;
}
Comment thread
roblourens marked this conversation as resolved.
}

toJSON(): ISerializableChatResponseData {
Expand Down
Loading