[Error] unhandlederror-Cannot read properties of undefined (reading 'search')

[vs-code-engineering]

Error Message

unhandlederror-Cannot read properties of undefined (reading 'search')

Stack Trace

    at S6.openSearch (./src/vs/browser/extensionsWorkbenchService.ts:1616:0)

Raw Stack Trace (minified)

TypeError: Cannot read properties of undefined (reading 'search')     at S6.openSearch (out/vs/sessions/sessions.desktop.main.js:2972:26046)

Details

Property	Value
Bucket ID	42fe0e93-be38-67db-71b0-df46b3e47c61
Version	1.117.0-insider
Commit	98b4d3e2
Last Seen	Wed Apr 15 2026 23:38:08 GMT+0000 (Coordinated Universal Time)
Platforms	Windows, Mac, Linux
Product	Agents

---

This issue was automatically created from the VS Code Errors Dashboard

[vs-code-engineering]

🔍 Error Investigation

Summary

openSearch() in extensionsWorkbenchService.ts crashes with Cannot read properties of undefined (reading 'search') in the Agents product. The method calls viewPaneContainer.search(searchValue) without null-checking the result of openViewContainer(). In the Agents/Sessions window, the Extensions viewlet may not be available, so the view pane container is undefined. This is the same root cause as #309920 (bucket 22108fd1 on 1.116.0-insider) — this issue tracks a different bucket ID (42fe0e93) from the 1.117.0-insider build at commit 98b4d3e2, which was cut before the fix landed.

Status: ✅ Already fixed by PR #309950 (merged Apr 14, 2026). The erroring commit 98b4d3e2 predates the fix merge. Subsequent insider builds include the fix.

Culprit Commit

Field	Value
Commit	e9c8a5c7
Author	@sandy081
PR	#308478
Message	disable copilot chat extension by default and adopt accordingly
Why	This commit removed ChatContextKeys.Setup.disabled guards from multiple code paths, causing agent/tool registrations and chat features to activate in scenarios where they were previously suppressed. In the Agents window, this enables code paths that call openSearch() (e.g., plugin recommendations) where the Extensions viewlet cannot be opened.

Code Flow

sequenceDiagram
    participant Caller as Chat/Plugin Action
    participant EWS as ExtensionsWorkbenchService
    participant VS as ViewsService
    participant SP as SidebarPart

    Caller->>EWS: openSearch(searchValue)
    EWS->>VS: openViewContainer(VIEWLET_ID, true)
    VS->>SP: openPaneComposite(id)
    Note over SP: ⚠️ Root cause:<br/>Extensions viewlet cannot open<br/>in Agents/Sessions window
    SP-->>VS: undefined
    VS-->>EWS: undefined
    EWS->>EWS: ?.getViewPaneContainer() → undefined
    Note over EWS: 💥 viewPaneContainer.search(searchValue)<br/>TypeError: Cannot read 'search' of undefined

Loading

Affected Files

File	Role
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts (L1614-1620)	Crash site — openSearch() lacked null guard on viewPaneContainer
src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts	Modified by culprit — removed disabled checks enabling more code paths
src/vs/workbench/contrib/chat/browser/chatParticipant.contribution.ts	Modified by culprit — chat view shown in more scenarios

Repro Steps

1. Open the Agents window (sessions desktop product)
2. Trigger an action that calls openSearch() — e.g., open a workspace with recommended agent plugins, click "Show Plugins", or run a command that triggers extension search
3. The Extensions viewlet fails to open and viewPaneContainer is undefined, causing the crash

Fix Proposal

Status: ✅ Already fixed in PR #309950 (merged Apr 14, 2026)

Fix location: src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts → openSearch()

Approach: Added a null guard for viewPaneContainer before calling .search() and .focus(). The as cast was widened to include undefined to match runtime behavior. The method now silently no-ops when the view pane container is unavailable.

Recommended Owner

@bryanchen-d — Current assignee, authored the fix PR #309950. Original culprit commit author @sandy081 is assigned on the sibling issue #309920.

Related Issues

• [Unhandled Error] Cannot read properties of undefined (reading 'search') #309920 — Same error, bucket 22108fd1 on 1.116.0-insider (closed, fixed by PR fix: guard openSearch against undefined view pane container #309950)
• This issue can likely be closed as a duplicate of [Unhandled Error] Cannot read properties of undefined (reading 'search') #309920 since the fix has already been merged.

Generated by errors-investigate · ● 4.4M · ◷