Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Timeline feature’s workbench contributions by separating ITimelineService singleton registration into its own “service contribution” module, enabling consumers (like the Agents window) to depend on the service without bringing in the Timeline view/UI contributions.
Changes:
- Added a new
timeline.service.contribution.tsthat registersITimelineServiceas a delayed singleton. - Updated the main workbench entrypoint to import both the Timeline UI contribution and the new service contribution.
- Updated the Sessions (Agents window) entrypoint to import only the service contribution (dropping the Timeline UI contribution).
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/workbench.common.main.ts |
Ensures both Timeline UI and service registration are loaded in the standard workbench. |
src/vs/workbench/contrib/timeline/browser/timeline.service.contribution.ts |
New side-effect module that registers ITimelineService (TimelineService) as a delayed singleton. |
src/vs/workbench/contrib/timeline/browser/timeline.contribution.ts |
Removes service registration from the UI contribution to keep it focused on view/commands/menus/config. |
src/vs/sessions/sessions.common.main.ts |
Loads only the Timeline service in Sessions (Agents window), avoiding Timeline view/UI contributions. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
alexr00
approved these changes
Apr 22, 2026
roblourens
added a commit
that referenced
this pull request
Apr 22, 2026
…ion (#311978) * extensions: split devtoolsExtensionHost action into its own contribution Pull DebugExtensionHostInDevToolsAction registration out of extensions.contribution.ts into a new devtoolsExtensionHost.contribution.ts so the Agents app (vs/sessions) can opt into just this action without importing the full electron-browser extensions contribution. Mirrors the recent timeline.contribution split (#311882). The action only depends on services already registered in the Agents app: IExtensionService, INativeHostService, IQuickInputService. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * extensions: move devtoolsExtensionHost import to debug section (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.