extensions: split devtoolsExtensionHost action into its own contribution#311978
Merged
roblourens merged 2 commits intomainfrom Apr 22, 2026
Merged
extensions: split devtoolsExtensionHost action into its own contribution#311978roblourens merged 2 commits intomainfrom
roblourens merged 2 commits intomainfrom
Conversation
Pull DebugExtensionHostInDevToolsAction registration out of extensions.contribution.ts into a new devtoolsExtensionHost.contribution.ts so the Agents app (vs/sessions) can opt into just this action without importing the full electron-browser extensions contribution. Mirrors the recent timeline.contribution split (#311882). The action only depends on services already registered in the Agents app: IExtensionService, INativeHostService, IQuickInputService. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors registration of DebugExtensionHostInDevToolsAction into a dedicated contribution so the Agents app (vs/sessions) can opt into that single command without importing the full desktop extensions contribution set.
Changes:
- Added a new
devtoolsExtensionHost.contribution.tsthat registersDebugExtensionHostInDevToolsAction. - Removed the devtools action registration from
extensions.contribution.ts. - Wired the new contribution into both
workbench.desktop.main.ts(no behavior change) andsessions.desktop.main.ts(enables the command in Agents).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/workbench.desktop.main.ts | Imports the new devtools extension-host contribution for desktop workbench. |
| src/vs/workbench/contrib/extensions/electron-browser/extensions.contribution.ts | Stops registering the devtools extension-host action from the broader extensions contribution. |
| src/vs/workbench/contrib/extensions/electron-browser/devtoolsExtensionHost.contribution.ts | New standalone contribution that registers DebugExtensionHostInDevToolsAction. |
| src/vs/sessions/sessions.desktop.main.ts | Imports the standalone contribution so the command is available in the Agents desktop app. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 1
Contributor
Screenshot ChangesBase: Changed (5)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Light
| Before | After |
|---|---|
 |
 |
(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anthonykim1
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls
DebugExtensionHostInDevToolsActionregistration out ofextensions.contribution.tsinto a newdevtoolsExtensionHost.contribution.tsso the Agents app (vs/sessions) can opt into just this action without importing the full electron-browser extensions contribution.Mirrors the recent timeline split in #311882.
What changed
src/vs/workbench/contrib/extensions/electron-browser/devtoolsExtensionHost.contribution.ts— registersDebugExtensionHostInDevToolsAction.extensions.contribution.tsno longer imports/registers that action.workbench.desktop.main.tsnow imports the new contribution (no behavior change for VS Code).sessions.desktop.main.tsimports the new contribution, so the Debug Extension Host In Dev Tools command is now available in the Agents app.Why
The command is genuinely useful when debugging the extension host inside the Agents app, but it had never been wired up there. The other debug actions (
DebugExtensionHostInNewWindowAction,DebugRendererInNewWindowAction,DebugExtensionHostAndRendererAction,DebugExtensionsContribution) are intentionally not included because they require additional services not currently in Agents (IDebugService,IExtensionHostDebugService,IProgressService, etc.). The dev-tools action only needs services already registered:IExtensionService— vianativeExtensionService.jsINativeHostService— vianativeHostService.jsIQuickInputService— viaquickInputService.jsSo this brings the action over with no new service registrations in the Agents app.
(Written by Copilot)