nes: lang ctx: register for NES as well#312358
Merged
Conversation
gated with NES setting for including lang ctx Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the existing TypeScript language context provider registration so it can also participate in NES (Next Edit Suggestions) language-context requests, aligning the TypeScript context pipeline with other NES-enabled context providers in the Copilot extension.
Changes:
- Register the TypeScript context provider for
ProviderTarget.NESin addition toProviderTarget.Completions. - Minor import organization change (moved
CancellationTokenimport).
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/typescriptContext/vscode-node/languageContextService.ts | Registers the TypeScript context provider for NES requests via ILanguageContextProviderService targets. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
| @@ -1975,7 +1975,7 @@ export class InlineCompletionContribution implements vscode.Disposable, TokenBud | |||
| } | |||
|
|
|||
| // Register with chat always. | |||
There was a problem hiding this comment.
The comment "Register with chat always." is now misleading since this call registers the provider for both ProviderTarget.Completions and ProviderTarget.NES. Please update the comment to reflect the actual targets (or split the registrations if the intent differs by target).
Suggested change
| // Register with chat always. | |
| // Register with the language context provider service for completions and NES. |
alexr00
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gated with NES setting for including lang ctx
Co-authored-by: Copilot copilot@github.com