Skip to content

nes: lang ctx: register for NES as well #312358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulugbekna merged 1 commit into from
Apr 24, 2026
+2 −2
Merged

nes: lang ctx: register for NES as well #312358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/copilot/src/extension/typescriptContext/vscode-node/languageContextService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ import { ILogService } from '../../../platform/log/common/logService';
import { IExperimentationService } from '../../../platform/telemetry/common/nullExperimentationService';
import { ITelemetryService } from '../../../platform/telemetry/common/telemetry';
import { Queue } from '../../../util/vs/base/common/async';
import { CancellationToken } from '../../../util/vs/base/common/cancellation';
import { DisposableStore } from '../../../util/vs/base/common/lifecycle';
import { generateUuid } from '../../../util/vs/base/common/uuid';
import * as protocol from '../common/serverProtocol';
import { InspectorDataProvider } from './inspector';
import { ThrottledDebouncer } from './throttledDebounce';
import { ContextItemResultBuilder, ContextItemSummary, ResolvedRunnableResult, type OnCachePopulatedEvent, type OnContextComputedEvent, type OnContextComputedOnTimeoutEvent } from './types';
import { CancellationToken } from '../../../util/vs/base/common/cancellation';

const currentTokenBudget: number = 8 * 1024;

Expand Down Expand Up @@ -1975,7 +1975,7 @@ export class InlineCompletionContribution implements vscode.Disposable, TokenBud
}

// Register with chat always.
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "Register with chat always." is now misleading since this call registers the provider for both ProviderTarget.Completions and ProviderTarget.NES. Please update the comment to reflect the actual targets (or split the registrations if the intent differs by target).

Suggested change
// Register with chat always.
// Register with the language context provider service for completions and NES.

Copilot uses AI. Check for mistakes.
this.registrations.add(this.languageContextProviderService.registerContextProvider(provider, [ProviderTarget.Completions]));
this.registrations.add(this.languageContextProviderService.registerContextProvider(provider, [ProviderTarget.Completions, ProviderTarget.NES]));
this.telemetrySender.sendInlineCompletionProviderTelemetry(KnownSources.completion, true);
logService.info('Registered TypeScript context provider with Copilot inline completions.');
} catch (error) {
Expand Down
Loading