ci: switch PR workflows back to 1ES self-hosted runners with JobId#313128
Merged
ci: switch PR workflows back to 1ES self-hosted runners with JobId#313128
Conversation
Re-applies #311975 (reverted in #312033). Adds per-run+attempt JobId labels to scope 1ES agents to specific GitHub Actions runs and prevent intermittent runner cancellations. Also switches the pr.yml compile job's GITHUB_TOKEN from the ephemeral repo-scoped runner token to secrets.VSCODE_OSS so cross-repo GitHub API release fetches (vscode-js-debug, vscode-js-debug-companion, vscode-js-profile-visualizer, etc.) authenticate properly. On 1ES pools the shared egress IPs hit the anonymous 60/hr api.github.com rate limit and produced 403 fan-out across PRs last time.
Match the historical pattern from before #255987 — fork PRs can't access secrets.VSCODE_OSS, so use the conditional to pick GITHUB_TOKEN for forks.
Contributor
There was a problem hiding this comment.
Pull request overview
Switches the PR GitHub Actions workflows back to 1ES self-hosted runner pools and scopes each job to a unique agent via a per-run/attempt JobId label, while also restoring authenticated GitHub API access for the PR compile path to avoid anonymous rate limiting on shared 1ES egress IPs.
Changes:
- Update
runs-onfor PR and reusable test workflows to target 1ES pools and add a uniqueJobId=...label per job. - In
pr.yml’s compile job, routeGITHUB_TOKENtosecrets.VSCODE_OSSfor same-repo PRs (with fork fallback tosecrets.GITHUB_TOKEN) on the dependency install and compile/hygiene steps. - Apply the same 1ES +
JobIdrunner selection to the node-modules workflow jobs.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr.yml | Move selected PR jobs to 1ES runners with JobId; use VSCODE_OSS for authenticated GitHub API access in compile-related steps with fork-aware fallback. |
| .github/workflows/pr-win32-test.yml | Run reusable Windows PR tests on 1ES with a per-invocation JobId including inputs.job_name for disambiguation. |
| .github/workflows/pr-linux-cli-test.yml | Run reusable Linux CLI tests on 1ES with a per-invocation JobId including inputs.job_name. |
| .github/workflows/pr-node-modules.yml | Run node-modules CI jobs on 1ES with per-job JobId labels (including adding it to the existing 1ES Windows job). |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
rzhao271
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies #311975 (reverted in #312033). Switches PR workflow Ubuntu/Windows jobs back to the 1ES self-hosted pools and adds a per-run+attempt
JobIdlabel to scope each agent to a specific GitHub Actions run, preventing the intermittent 1ES cancellations seen previously.This time, also wires the
pr.ymlcompile job'sGITHUB_TOKENback tosecrets.VSCODE_OSS(with the historical fork-aware fallback). On 1ES pools, the shared egress IPs hit the anonymous 60/hr `api.github.com` rate limit during cross-repo release fetches (`vscode-js-debug`, `vscode-js-debug-companion`, `vscode-js-profile-visualizer`, …), producing 403 fan-out across PRs — that was the actual cause of the failures that triggered the previous revert, not 1ES itself.Session Context
Investigation of the previous revert (#312033):
Pools (unchanged):
Changes
Note: `pr-linux-test.yml` is intentionally left on `ubuntu-24.04` — that move happened after #311975 to address a fontconfig SIGSEGV.
Closes follow-up to #312033.