Skip to content

Revert "ci: switch PR workflows back to 1ES self-hosted runners with JobId"#312033

Merged
Yoyokrazy merged 1 commit intomainfrom
revert-311975-agents/runner-pool-reconfiguration-1es-8932bbef
Apr 22, 2026
Merged

Revert "ci: switch PR workflows back to 1ES self-hosted runners with JobId"#312033
Yoyokrazy merged 1 commit intomainfrom
revert-311975-agents/runner-pool-reconfiguration-1es-8932bbef

Conversation

@Yoyokrazy
Copy link
Copy Markdown
Collaborator

Reverts #311975

Copilot AI review requested due to automatic review settings April 22, 2026 22:49
Comment thread .github/workflows/pr-node-modules.yml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts a previous CI configuration change by switching PR workflows away from 1ES self-hosted runners (with JobId=... labels) back to GitHub-hosted runners, to restore the prior execution environment for PR validation.

Changes:

  • Update PR workflow jobs to run on ubuntu-22.04 / windows-2022 instead of 1ES self-hosted pools with JobId labels.
  • Update reusable Windows and Linux CLI test workflows to use GitHub-hosted runners.
  • Partially revert runner selection in the node_modules workflow (Linux/compile moved to GitHub-hosted; Windows remains 1ES self-hosted).
Show a summary per file
File Description
.github/workflows/pr.yml Switch main PR jobs (compile + Copilot checks/tests) back to GitHub-hosted runners.
.github/workflows/pr-win32-test.yml Switch reusable Windows test workflow back to windows-2022.
.github/workflows/pr-node-modules.yml Switch compile/Linux node_modules jobs back to ubuntu-22.04; Windows job still targets 1ES self-hosted.
.github/workflows/pr-linux-cli-test.yml Switch reusable Linux CLI test workflow back to ubuntu-22.04.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 1

Comment thread .github/workflows/pr-node-modules.yml
@Yoyokrazy Yoyokrazy enabled auto-merge (squash) April 22, 2026 22:54
@Yoyokrazy Yoyokrazy merged commit d00e135 into main Apr 22, 2026
30 checks passed
@Yoyokrazy Yoyokrazy deleted the revert-311975-agents/runner-pool-reconfiguration-1es-8932bbef branch April 22, 2026 23:10
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants