nes: feat: ghost-text-like behavior#313206
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an experiment-gated “ghost-text-like” behavior for NES by tracking whether a cached suggestion was previously rendered as inline (ghost text) and suppressing re-serving it in non-inline form.
Changes:
- Introduces a team-internal experiment setting to enable/disable the behavior gate.
- Threads a reference to the underlying NES cache entry through
NextEditResultand records awasRenderedAsInlineSuggestionflag. - Suppresses non-inline re-show of previously-inline cached NES suggestions; adds a caching-focused regression test.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/configuration/common/configurationService.ts | Adds experiment-based config key to control the “mimic ghost text behavior” gating. |
| extensions/copilot/src/extension/inlineEdits/vscode-node/inlineCompletionProvider.ts | Implements the suppression gate and marks cache entries when an inline completion is shown. |
| extensions/copilot/src/extension/inlineEdits/test/node/nextEditProviderCaching.spec.ts | Adds test coverage for exposing/persisting cache entry references and flags across cache lookups. |
| extensions/copilot/src/extension/inlineEdits/node/nextEditResult.ts | Extends NextEditResult to carry a cache entry reference for consumers. |
| extensions/copilot/src/extension/inlineEdits/node/nextEditProvider.ts | Plumbs cache entry references into NextEditResult for both cached and freshly-cached results. |
| extensions/copilot/src/extension/inlineEdits/node/nextEditCache.ts | Adds wasRenderedAsInlineSuggestion flag to cached edit entries. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
alexr00
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.