Skip to content

nes: feat: ghost-text-like behavior#313206

Merged
ulugbekna merged 2 commits intomainfrom
ulugbekna/agents/nes-inline-suggestion-cache-logic
Apr 29, 2026
Merged

nes: feat: ghost-text-like behavior#313206
ulugbekna merged 2 commits intomainfrom
ulugbekna/agents/nes-inline-suggestion-cache-logic

Conversation

@ulugbekna
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2026 11:41
@ulugbekna ulugbekna enabled auto-merge (squash) April 29, 2026 11:41
@ulugbekna ulugbekna self-assigned this Apr 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an experiment-gated “ghost-text-like” behavior for NES by tracking whether a cached suggestion was previously rendered as inline (ghost text) and suppressing re-serving it in non-inline form.

Changes:

  • Introduces a team-internal experiment setting to enable/disable the behavior gate.
  • Threads a reference to the underlying NES cache entry through NextEditResult and records a wasRenderedAsInlineSuggestion flag.
  • Suppresses non-inline re-show of previously-inline cached NES suggestions; adds a caching-focused regression test.
Show a summary per file
File Description
extensions/copilot/src/platform/configuration/common/configurationService.ts Adds experiment-based config key to control the “mimic ghost text behavior” gating.
extensions/copilot/src/extension/inlineEdits/vscode-node/inlineCompletionProvider.ts Implements the suppression gate and marks cache entries when an inline completion is shown.
extensions/copilot/src/extension/inlineEdits/test/node/nextEditProviderCaching.spec.ts Adds test coverage for exposing/persisting cache entry references and flags across cache lookups.
extensions/copilot/src/extension/inlineEdits/node/nextEditResult.ts Extends NextEditResult to carry a cache entry reference for consumers.
extensions/copilot/src/extension/inlineEdits/node/nextEditProvider.ts Plumbs cache entry references into NextEditResult for both cached and freshly-cached results.
extensions/copilot/src/extension/inlineEdits/node/nextEditCache.ts Adds wasRenderedAsInlineSuggestion flag to cached edit entries.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 1

Comment thread extensions/copilot/src/extension/inlineEdits/node/nextEditProvider.ts Outdated
@ulugbekna ulugbekna merged commit 3440287 into main Apr 29, 2026
26 checks passed
@ulugbekna ulugbekna deleted the ulugbekna/agents/nes-inline-suggestion-cache-logic branch April 29, 2026 13:35
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants