Fix deprecated terminal sandbox setting fallback#313593
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes deprecated terminal sandbox setting fallback so chat.agent.sandbox is only used when that exact deprecated key is explicitly set by the user, avoiding accidental fallback caused by namespace/child-setting objects returned from inspect().
Changes:
- Update deprecated fallback logic to additionally require the deprecated key to be present in
configurationService.keys().user. - Add a test covering namespace conflicts where
inspect('chat.agent.sandbox')returns an object due to child settings. - Keep/adjust tests ensuring deprecated settings are ignored outside user scope while preserving exact-key fallback behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts | Tightens deprecated fallback by checking the exact deprecated key exists in user-configured keys. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts | Adds coverage for namespace-conflict behavior and preserves explicit deprecated-key fallback coverage. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
benvillalobos
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #313409