Fix forced sandbox issue#313409
Merged
Merged
Conversation
Contributor
jruales
commented
Apr 30, 2026
jruales
commented
- Fixes Setting chat.agent.sandbox.fileSystem.mac forcefully enables chat.agent.sandbox.enabled on restart #313387
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a configuration migration edge case where the deprecated chat.agent.sandbox key is now also a namespace prefix for newer settings, which caused the sandbox to be force-enabled on restart when filesystem sandbox settings were present.
Changes:
- Updates the
chat.agent.sandboxmigration to only run when the deprecated setting value is actually a boolean. - Prevents writing back
undefinedto the deprecated prefix key when it’s acting as a derived namespace object, avoiding clobbering/side effects on sub-settings.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Hardens the deprecated chat.agent.sandbox configuration migration to avoid misinterpreting namespace objects and forcing chat.agent.sandbox.enabled to "on". |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
DonJayamanne
approved these changes
Apr 30, 2026
Collaborator
|
Thank you very much for this one 🙏 |
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.