Skip to content

Always send reasoning for same responses model#314998

Merged
chrmarti merged 1 commit intomainfrom
chrmarti/defiant-termite
May 7, 2026
Merged

Always send reasoning for same responses model#314998
chrmarti merged 1 commit intomainfrom
chrmarti/defiant-termite

Conversation

@chrmarti
Copy link
Copy Markdown
Collaborator

@chrmarti chrmarti commented May 7, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 7, 2026 12:36
@chrmarti chrmarti enabled auto-merge (rebase) May 7, 2026 12:36
@chrmarti chrmarti self-assigned this May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Copilot tool-calling prompt rendering to include “thinking/reasoning” data in historical rounds when using the Responses API and the historical round was produced by the same model, by tracking a per-round model identifier.

Changes:

  • Add modelId to IToolCallRound / ToolCallRound and populate it from the tool-calling loop.
  • Render thinking data for historical rounds only when apiType === 'responses' and round.modelId matches the active endpoint model.
  • Add unit tests covering thinking inclusion/exclusion for historical vs non-historical rendering.
Show a summary per file
File Description
extensions/copilot/src/extension/tools/node/test/toolCalling.spec.tsx Adds tests validating when historical thinking is included/dropped.
extensions/copilot/src/extension/prompts/node/panel/toolCalling.tsx Adjusts ChatToolCalls rendering logic to conditionally include thinking (and gates phase by modelId).
extensions/copilot/src/extension/prompt/common/toolCallRound.ts Renames/stores per-round model identifier (modelId) on ToolCallRound.
extensions/copilot/src/extension/prompt/common/intents.ts Updates IToolCallRound schema to replace phaseModelId with modelId.
extensions/copilot/src/extension/intents/node/toolCallingLoop.ts Populates modelId for each produced ToolCallRound.

Copilot's findings

  • Files reviewed: 5/5 changed files
  • Comments generated: 3

Comment thread extensions/copilot/src/extension/prompts/node/panel/toolCalling.tsx Outdated
Comment thread extensions/copilot/src/extension/prompt/common/intents.ts
@chrmarti chrmarti marked this pull request as draft May 7, 2026 12:48
auto-merge was automatically disabled May 7, 2026 12:48

Pull request was converted to draft

@chrmarti chrmarti merged commit f73b3a3 into main May 7, 2026
26 checks passed
@chrmarti chrmarti deleted the chrmarti/defiant-termite branch May 7, 2026 13:51
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants