Always send reasoning for same responses model#314998
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Copilot tool-calling prompt rendering to include “thinking/reasoning” data in historical rounds when using the Responses API and the historical round was produced by the same model, by tracking a per-round model identifier.
Changes:
- Add
modelIdtoIToolCallRound/ToolCallRoundand populate it from the tool-calling loop. - Render thinking data for historical rounds only when
apiType === 'responses'andround.modelIdmatches the active endpoint model. - Add unit tests covering thinking inclusion/exclusion for historical vs non-historical rendering.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/tools/node/test/toolCalling.spec.tsx | Adds tests validating when historical thinking is included/dropped. |
| extensions/copilot/src/extension/prompts/node/panel/toolCalling.tsx | Adjusts ChatToolCalls rendering logic to conditionally include thinking (and gates phase by modelId). |
| extensions/copilot/src/extension/prompt/common/toolCallRound.ts | Renames/stores per-round model identifier (modelId) on ToolCallRound. |
| extensions/copilot/src/extension/prompt/common/intents.ts | Updates IToolCallRound schema to replace phaseModelId with modelId. |
| extensions/copilot/src/extension/intents/node/toolCallingLoop.ts | Populates modelId for each produced ToolCallRound. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
auto-merge was automatically disabled
May 7, 2026 12:48
Pull request was converted to draft
3967952 to
aafa29a
Compare
deepak1556
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.