"Changing the task execution engine requires restarting VS Code. The change is ignored"

[chrisdias]

Version 1.15.0-insider (1.15.0-insider)
c26f8a3
Mac

I'm working in the vscode-docker repository and I keep getting this prompt when checking out different branches.

I have not been able to identify what is causing it.

[kieferrm]

@chrisdias anything interesting difference in your tasks.json between those branches?

[chrisdias]

ok got it...

auto-save on (after delay)
scaffold out a new extension
open the folder
F1, type in task, then pick the npm task
delete tasks.json

result: you get the warning message

open launch.json
make any change to launch.json

result: on the auto-save of the, you keep getting this warning message. it keeps popping up over and over!

in my original scenario I was moving between branches where one branch had a tasks.json and the second did not. I suspect I was moving between 2.0 and 1.0 of tasks.

Regardless, as a user the warning message is not actionable. It says that VS Code has to be restarted, but then it says its ignoring the change, and after ~5sec the warning goes away.

[dbaeumer]

The actual change is ignored. If you reload the workbench the change will be expected. I can tweak the message however this is IMO not critical for July.

[chrisdias]

I keep running into this in "daily" development of the vscode-docker extension, whenever I edit launch.json.

What I don't quite understand is as a user, what do I do with this message? I don't restart VS Code but everything seems to work OK.

Do we really need it?

//cc: @kieferrm for end game consideration.

[dbaeumer]

I can't reproduce this when editing the launch.json file. @chrisdias do you have steps so I can try to see why you are seeing this when editing the launch.json file.

The message is shown when the user switches the task execution engine from the old output runner to the new terminal runner or vice versa. It happens when the user does one of these things:

• change the version of the tasks.json from 0.1.0 to 2.0.0 or vice versa
• add a runner property to the file and set it to terminal for version 0.1.0
• have a 0.1.0 file and deletes it.

The right fix for this is to add a Reload button to the message so that the user can reload the Window in place. After having it reloaded the new execution engine is picked up. However I think the above three situations are not so common that they require this to be fixed in the end game.