Show session types as disabled with Sign in button when user is offline#321861
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens session-type availability logic so that when the user is signed out, Copilot-backed session types (e.g. Agent Host / Copilot CLI / Cloud) appear disabled and surface a Sign in affordance instead of appearing selectable.
Changes:
- Added a new
SessionTypeAvailability.SignInRequiredstate and corresponding description/hover/label strings with aworkbench.action.chat.triggerSetupsign-in link. - Updated
getSessionTypeAvailabilityto returnSignInRequiredwhenChatEntitlement.Unknown(signed out) for contributed session types. - Expanded unit coverage for signed-out scenarios (including cases where Auto fallback or targeted models would otherwise make the type appear available).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/sessionTypeAvailability.ts | Adds SignInRequired and sign-in messaging; updates availability logic for signed-out users. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/sessionTypeAvailability.test.ts | Adds tests validating signed-out gating behavior across contributed session-type configurations. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
pwang347
previously approved these changes
Jun 18, 2026
dmitrivMS
added
the
agent-host
alexdima
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321805