Fix browser URL focus quirks#322995
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses focus-driven UX quirks in the integrated browser URL bar, specifically preventing the URL picker/dropdown from auto-opening during workspace/window switching or certain focus transfers.
Changes:
- Updates the URL bar’s focus/click state machine to avoid auto-opening the picker on already-focused clicks and to ignore focus transfers coming from quick input/outside-workbench scenarios.
- Defers browser editor URL-focus behavior by one tick during tab activation to reduce focus contention with the tab control.
- Adds coverage for the new click/focus behavior and clears document selection when forcing browser-container focus.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/test/electron-browser/widgets/browserUrlBarWidget.test.ts | Adds new tests for picker-open behavior on focused vs mouse-focused clicks. |
| src/vs/workbench/contrib/browserView/electron-browser/widgets/browserUrlBarWidget.ts | Refines focus/click handling to prevent unwanted picker auto-open and to account for quick input focus transfers. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserNavigationFeatures.ts | Defers tryFocus() behavior by one macrotask to avoid tab activation focus conflicts. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Clears selection ranges when forcing focus to the browser container. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 3
hediet
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322559