Revert "Fix single tool calls getting stuck inside thinking parts"#323184
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the earlier change that attempted to promote a single tool invocation out of the “thinking” container, after it caused unintended layout/padding regressions in the chat widget.
Changes:
- Removes the “single tool promotion” bookkeeping and retry-on-complete logic in
ChatThinkingContentPart. - Reintroduces a guard that prevents restoring a single item when its DOM has multiple child elements.
- Deletes the regression tests that validated promotion/restoration edge cases for lone tool invocations.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatThinkingContentPart.test.ts | Removes regression tests for lone-tool promotion/restoration behaviors. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts | Reverts single-tool promotion support by removing original-position tracking/retry logic and restoring the multi-child restore guard. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Low
vritant24
approved these changes
Jun 26, 2026
joshspicer
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #323059
reverting because it ended up flattening some of the items we pulled out of thinking, leading to weird padding changes....trying to find a better fix for this atm.