Enhance Copilot command handling: log unhandled command result kinds and refine trigger characters#323384
Merged
Merged
Conversation
…and refine trigger characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens agent-host slash completion triggering and improves observability for forward-compatible Copilot slash command execution by logging unknown runtime result kinds.
Changes:
- Stop advertising
' '(space) as a completion trigger for Copilot slash command completions, reducing unnecessary completion requests after the command token ends. - Fix a local variable typo (
aliasses→aliases) in the Copilot slash command completion provider. - Add a
defaultcase to the Copilot runtime slash-command result handler to warn-log unrecognizedresult.kindvalues.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/copilot/copilotSlashCommandCompletionProvider.ts | Removes space as a trigger character (aligning with extractLeadingSlashToken behavior) and fixes a local variable name. |
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Adds warning telemetry via logs for unhandled slash command result kinds to aid diagnosis when runtime SDK returns newer variants. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
dmitrivMS
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.