AgentHost - fix commit changes operation visibility#323459
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how Agent Host changeset operations are computed/advertised, with a focus on when the “Commit Changes” operation should appear.
Changes:
- Updates the commit operation provider to consider
changesetKindandgitHubState.pullRequestUrlwhen deciding whether to advertise “Commit Changes”. - Changes the changeset operation service’s internal operation collection to always return an array (including empty), affecting how operation state is dispatched.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/agentHostCommitOperationProvider.ts | Adds additional gating for advertising the commit operation based on changeset kind and GitHub PR state. |
| src/vs/platform/agentHost/node/agentHostChangesetOperationService.ts | Changes internal operation aggregation to return an array unconditionally, impacting whether operations are omitted vs published as empty. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Low
benibenj
approved these changes
Jun 29, 2026
Member
Author
|
@microsoft-github-policy-service rerun |
Member
Author
|
@microsoft-github-policy-service rerun |
lszomoru
added a commit
that referenced
this pull request
Jun 29, 2026
|
Ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.