Skip to content

[cherry-pick] Disable semantic_search on BYOK/custom endpoints#323610

Merged
bhavyaus merged 1 commit into
release/1.127from
cherry-pick/323605
Jun 29, 2026
Merged

[cherry-pick] Disable semantic_search on BYOK/custom endpoints#323610
bhavyaus merged 1 commit into
release/1.127from
cherry-pick/323605

Conversation

@vs-code-engineering

Copy link
Copy Markdown
Contributor

Cherry-pick of #323605 from main.

Fixes #322525

Problem

When using a BYOK / custom (non‑CAPI) endpoint — e.g. a local llama.cpp model — and the GitHub Authentication Provider extension is disabled (--disable-extension vscode.github-authentication), invoking the semantic_search tool aborts the whole chat turn:

Fix

Gate semantic_search (ToolName.Codebase) off for non‑CAPI endpoints, alongside the specialized subagents that are already restricted to CAPI in getAgentTools. Because this is applied through the getEnabledTools filter callback, it takes precedence over a manual tool‑picker enablement (the exact repro in the issue), so the tool is never offered when it can't work.

Copilot AI review requested due to automatic review settings June 29, 2026 20:26
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot can't review bot-authored pull requests automatically. A user with Copilot access can request a review manually.

@bhavyaus bhavyaus enabled auto-merge (squash) June 29, 2026 20:27
@bhavyaus bhavyaus merged commit 0a04e19 into release/1.127 Jun 29, 2026
29 checks passed
@bhavyaus bhavyaus deleted the cherry-pick/323605 branch June 29, 2026 21:11
@vs-code-engineering vs-code-engineering Bot added this to the 1.127.0 milestone Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants