Agents - clear changes when switching between sessions, but not when siwtching between changesets#323918
Merged
Merged
Conversation
…siwtching between changesets
Contributor
There was a problem hiding this comment.
Pull request overview
Refines the Sessions “Changes” view loading behavior so the UI can distinguish between (a) switching sessions vs (b) switching changesets, enabling the view to clear the list on session switches while keeping the previous list during changeset transitions.
Changes:
- Split loading state into granular observables (
activeSessionChangesetsLoadingObs,activeSessionChangesetLoadingObs) and a combinedactiveSessionLoadingObs. - Refactored active session state computation to depend on the combined loading observable.
- Updated the Changes view rendering logic to only early-return (preserve current list) when switching changesets, not when switching sessions.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/changes/common/changesViewService.ts | Updates the service interface to expose granular + combined loading observables. |
| src/vs/sessions/contrib/changes/browser/changesViewService.ts | Implements new loading observables and refactors active session state derivation accordingly. |
| src/vs/sessions/contrib/changes/browser/changesView.ts | Adjusts UI rendering logic to preserve list during changeset loading but clear on session switch; updates to new loading observable name. |
| src/vs/sessions/contrib/changes/browser/changesMultiDiffSourceResolver.ts | Switches loading checks to the renamed combined loading observable. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Low
dmitrivMS
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.