Improve file list handling and UI elements - #324496
Merged
Benjamin Christopher Simmonds (benibenj) merged 2 commits intoJul 6, 2026
Merged
Conversation
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge
July 6, 2026 13:09
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
July 6, 2026 13:10
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the "Other Files" / changes UI in the Agents window (vs/sessions). It changes how deleted files are handled in reduceSessionFiles (deletions now net a file out of the list entirely instead of surfacing a Deleted entry), simplifies the session files row by dropping the A/M/D decoration badge, adds a collapsed-header file count that mirrors the customizations widget, and makes the changes tree pane grow-to-fit its content with a row-capped minimum and a bounded maximum.
Changes:
reduceSessionFilesnow removes files on delete/rename-source instead of marking themDeleted; tests updated and a new created-then-deleted case added.SessionFilesWidgetdrops the decoration badge, adds a collapsed-only file count in the header, and switches the header hover delegate to'mouse'.ChangesViewPanegrows the tree pane minimum size to fit content (capped byTREE_PANE_MIN_SIZE_MAX_ROWS) and applies bottom padding to the min/max size calculations.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/providers/agentHost/browser/agentHostSessionFiles.ts |
Replaces setDeleted with removeFile so deletes drop entries from the reduction map; updates doc comments. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostSessionFiles.test.ts |
Updates expectations for deletes/renames and adds a created-then-deleted test. |
src/vs/sessions/contrib/changes/browser/sessionFilesWidget.ts |
Removes the decoration badge template/rendering, adds collapsed file-count node, switches hover delegate. |
src/vs/sessions/contrib/changes/browser/media/sessionFilesWidget.css |
Removes badge styles, adds .session-files-widget-count styles. |
src/vs/sessions/contrib/changes/browser/changesView.ts |
Adds row-cap/padding constants and grows the tree pane min/max size to fit content. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Medium
Contributor
Screenshot ChangesBase: Changed (10)
|
| Before | After |
|---|---|
 |
 |
sessions/changes/changesView/AllSections_List/Light
| Before | After |
|---|---|
 |
 |
sessions/changes/changesView/TreeMode/Dark
| Before | After |
|---|---|
 |
 |
sessions/changes/changesView/TreeMode/Light
| Before | After |
|---|---|
 |
 |
sessions/changes/changesView/NoFileChangesWithOtherFiles/Dark
| Before | After |
|---|---|
 |
 |
sessions/changes/changesView/NoFileChangesWithOtherFiles/Light
| Before | After |
|---|---|
 |
 |
changes/sessionFilesWidget/WithFiles/Dark
| Before | After |
|---|---|
 |
 |
changes/sessionFilesWidget/WithFiles/Light
| Before | After |
|---|---|
 |
 |
changes/sessionFilesWidget/SingleCreatedFile/Dark
| Before | After |
|---|---|
 |
 |
changes/sessionFilesWidget/SingleCreatedFile/Light
| Before | After |
|---|---|
 |
 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Giuseppe Cianci (Giuspepe)
approved these changes
Jul 6, 2026
Vritant Bhardwaj (vritant24)
approved these changes
Jul 6, 2026
auto-merge was automatically disabled
July 6, 2026 20:53
Pull request was closed
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
July 6, 2026 20:56
Benjamin Christopher Simmonds (benibenj)
merged commit Jul 6, 2026
91190ee
into
main
54 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/superior-deer
branch
July 6, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce a maximum size for the tree pane, add a file count display in the header, and remove the decoration badge from the session files widget. Adjust the logic for handling deleted files to remove them entirely from the list rather than marking them as deleted.