Automations TPI feedback - #324659
Merged
Merged
Conversation
The secondary-toolbar inter-chip divider from chat.css drew an orphan vertical bar to the left of the Folder/Worktree chip, since it follows the Copilot CLI chip. Extend the existing divider suppression to cover the secondary toolbar. Fixes microsoft/vscode-internalbacklog#8304
The title bar used a translucent quickInputTitle stripe, so hovering the close button read as an overlapping box against the differently colored header. Anchor both the title bar and body to editorWidget.background so they match in every theme. Fixes microsoft/vscode-internalbacklog#8319
Copilot started reviewing on behalf of
Ben Villalobos (benvillalobos)
July 7, 2026 00:48
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Automations create/edit dialog styling and ensures the dialog saves an explicit session target instead of relying on implicit defaults, improving visual consistency and avoiding unintended fallbacks.
Changes:
- Aligns the automations modal background/titlebar styling with the dialog’s native theme background.
- Removes the orphan separator/divider in the dialog’s embedded chat toolbars (primary + secondary).
- Explicitly persists the session target (provider + session type) used by the modal.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css | Updates dialog/titlebar background tokens and suppresses toolbar dividers in both primary/secondary toolbars. |
| src/vs/sessions/contrib/automations/browser/automationDialogService.ts | Forces provider/session type onto create/update payloads to avoid implicit fallback behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 4
- Review effort level: Low
Switches color from quickInput-foreground to editorWidget-foreground on both the dialog body and titlebar. Ensures consistent theming with defaultDialogStyles across all VS Code themes.
… CLI Instead of hard-coding COPILOT_PROVIDER_ID and SessionType.CopilotCLI, read from form state and fall back to these defaults when undefined. This respects the session type binder's output on both create and update paths.
Ben Villalobos (benvillalobos)
force-pushed
the
bv/automations-tpi-fixes
branch
from
July 7, 2026 02:51
5c8b522 to
465945a
Compare
Ben Villalobos (benvillalobos)
marked this pull request as ready for review
July 7, 2026 03:54
Ben Villalobos (benvillalobos)
changed the title
roblourens
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/8304
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/8319
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/8334