Fix cache break hint when models are unavailable - #325444
Merged
Bhavya U (bhavyaus) merged 1 commit intoJul 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Suppresses cache-break warnings when the model picker has no usable models.
Changes:
- Centralizes model availability state.
- Adds cache-warning visibility logic and regression tests.
Show a summary per file
| File | Description |
|---|---|
chatModelPicker.ts |
Uses availability state to suppress irrelevant warnings. |
chatModelSelectionLogic.ts |
Adds cache-warning visibility helper. |
chatModelSelectionLogic.test.ts |
Tests warning suppression conditions. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
Comment on lines
+1558
to
1562
| // A "Models" placeholder (no badge) beats a dead-end label while unavailable — the hover and | ||
| // dropdown carry the Restricted Mode explanation and the Trust Workspace / Sign In action. | ||
| // "Activating..." is transient while models load after a Trust grant; "No models available" | ||
| // is the genuinely empty state (e.g. an agent-host session with no Auto fallback). | ||
| const modelLabel = unavailable |
roblourens
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325185.