Revert "Re-enable Chat Sandbox home-read smoke test by re-warming chat after restart" - #325636
Merged
Giuspepe merged 1 commit intoJul 13, 2026
Conversation
…t after …" This reverts commit e4556ce.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the unsuccessful post-restart chat warm-up fix from #325594 and disables the still-flaky sandbox smoke test.
Changes:
- Removes post-restart chat re-warming.
- Restores the home-directory
allowReadtest skip and tracking comment.
Show a summary per file
| File | Description |
|---|---|
test/smoke/src/areas/chat/chatSandbox.test.ts |
Reverts the warm-up workaround and skips the flaky test. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
benvillalobos
approved these changes
Jul 13, 2026
roblourens
approved these changes
Jul 13, 2026
Giuspepe
deleted the
revert-325594-gcianci/fix-flaky-sandbox-home-read-warmup
branch
July 13, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #325594 since it still fails https://dev.azure.com/monacotools/Monaco/_build/results?buildId=455360&view=logs&j=e352877c-ff47-5dec-32e2-b206099d9704&t=e3dd7514-b813-5e5e-156d-669f9d8e2cfc