Notification style breaks if filename contains markdown symbols (i.e. __)

[KazeZlat]

• VSCode Version: Code 1.16.0 (787b31c, 2017-09-06T16:27:49.891Z)
• OS Version: Windows_NT x64 10.0.15063

Steps to Reproduce:

1. Name an image with some name__contains__double__underscores
2. Try to open that image

You will see smth like this:

Probably need to escape filename
Reproduces without extensions: Yes

[joaomoreno]

What the...

@bpasero Do we pass errors through a Markdown parser?!

[bpasero]

Probably introduced via 7194723

@mjbvz

[mjbvz]

We don't support markdown in messages but do support formatted text. And for file actions specifically, we do explicitly enable formattedText: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/browser/fileActions.ts#L412

Looks like that may be the root cause here?

[mjbvz]

Whoops, that's the wrong code. It's actually this: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/message/browser/messageList.ts#L340

[bpasero]

Yeah, we seem to support formatted text in the message list. Maybe we should not format the text when an error enters the message list widget. Anyway, this does not seem like a big deal, but PR welcome.